Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2144)

Issue 217056: code review 217056: - removed exp/parser (support for old semicolon syntax) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by gri
Modified:
15 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

- removed exp/parser (support for old semicolon syntax) - go/ast: removed StringList (not needed anymore) - go/ast: changed import path and field list tag to a single string - updated all dependencies

Patch Set 1 #

Patch Set 2 : code review 217056: - removed exp/parser (support for old semicolon syntax) #

Total comments: 1

Patch Set 3 : code review 217056: - removed exp/parser (support for old semicolon syntax) #

Patch Set 4 : code review 217056: - removed exp/parser (support for old semicolon syntax) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2382 lines) Patch
M src/cmd/cgo/ast.go View 2 chunks +2 lines, -3 lines 0 comments Download
M src/cmd/godoc/index.go View 2 chunks +2 lines, -6 lines 0 comments Download
M src/cmd/gofmt/doc.go View 1 chunk +0 lines, -8 lines 0 comments Download
M src/cmd/gofmt/gofmt.go View 3 chunks +5 lines, -13 lines 0 comments Download
M src/pkg/Makefile View 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/exp/eval/eval_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/eval/expr.go View 1 chunk +0 lines, -14 lines 0 comments Download
M src/pkg/exp/eval/expr_test.go View 1 chunk +0 lines, -3 lines 0 comments Download
M src/pkg/exp/eval/stmt_test.go View 5 chunks +8 lines, -8 lines 0 comments Download
M src/pkg/exp/eval/world.go View 2 chunks +3 lines, -3 lines 0 comments Download
R src/pkg/exp/parser/Makefile View 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/exp/parser/interface.go View 1 chunk +0 lines, -203 lines 0 comments Download
R src/pkg/exp/parser/parser.go View 1 chunk +0 lines, -1972 lines 0 comments Download
R src/pkg/exp/parser/parser_test.go View 1 chunk +0 lines, -95 lines 0 comments Download
M src/pkg/go/ast/ast.go View 6 chunks +3 lines, -16 lines 0 comments Download
M src/pkg/go/ast/walk.go View 2 chunks +2 lines, -11 lines 0 comments Download
M src/pkg/go/parser/parser.go View 3 chunks +4 lines, -7 lines 0 comments Download
M src/pkg/go/printer/nodes.go View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 1 month ago (2010-02-19 23:49:45 UTC) #1
rsc
LGTM http://codereview.appspot.com/217056/diff/1019/23 File src/pkg/exp/eval/eval_test.go (right): http://codereview.appspot.com/217056/diff/1019/23#newcode46 src/pkg/exp/eval/eval_test.go:46: src := j.code + ";" // don't end ...
15 years, 1 month ago (2010-02-19 23:59:35 UTC) #2
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=4aea95bad2e2 *** - removed exp/parser (support for old semicolon syntax) - go/ast: ...
15 years, 1 month ago (2010-02-20 00:01:38 UTC) #3
rog
15 years, 1 month ago (2010-02-20 01:03:06 UTC) #4
> - go/ast: changed import path and field list tag to a single string

hurray!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b