Issue 216043: code review 216043: gc: fix this morning's bug fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 216043: code review 216043: gc: fix this morning's bug fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by rsc

Modified:
15 years, 1 month ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: fix this morning's bug fix

Patch Set 1 #

Patch Set 2 : code review 216043: gc: fix this morning's bug fix #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	src/cmd/8g/ggen.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/align.c	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/gc/dcl.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-19 02:31:11 UTC) #1