code review 21510045: go.blog: add Go 1.2 release article

go.blog: add Go 1.2 release article

[adg, 2013-11-05 01:55:32]

Hello r,

I'd like you to review this change to
https://code.google.com/p/go.blog

[r, 2013-11-05 06:20:51]

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.article
File content/go-12-is-released.article (right):

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:11: Pre-compiled binary distributions may be
downloaded from the
Pre-compiled and binary mean the same thing.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:18: We anticipate an equal or shorter interval
between 1.2 and 1.3.
s/an equal or shorter/a comparable/

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:33: package.
s/reflect/unsafe/

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:35: Goroutines are now
[[http://golang.org/doc/go1.2#preemption][pre-emptively scheduled]],
probably should briefly say what that means, because it's not the usual
definition. grab some text from the release notes and adjust.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:43: documentation for details.
mention upcoming blog post? i hope we push that out very soon after this one.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:46: performance of most programs. On the other
end, new restrictions on
no.
it should have no effect at all on most programs, but for a few cases (explain
what) it could make a big difference.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:60: bug reports to our dedicated contributors.
Your help is invaluable to the project.
maybe give some numbers?

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:61: 
d

[adg, 2013-11-05 06:38:16]

PTAL

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.article
File content/go-12-is-released.article (right):

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:11: Pre-compiled binary distributions may be
downloaded from the
On 2013/11/05 06:20:51, r wrote:
> Pre-compiled and binary mean the same thing.

Done.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:18: We anticipate an equal or shorter interval
between 1.2 and 1.3.
On 2013/11/05 06:20:51, r wrote:
> s/an equal or shorter/a comparable/

Done.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:33: package.
On 2013/11/05 06:20:51, r wrote:
> s/reflect/unsafe/

Done.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:35: Goroutines are now
[[http://golang.org/doc/go1.2#preemption][pre-emptively scheduled]],
On 2013/11/05 06:20:51, r wrote:
> probably should briefly say what that means, because it's not the usual
> definition. grab some text from the release notes and adjust.

Done.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:43: documentation for details.
On 2013/11/05 06:20:51, r wrote:
> mention upcoming blog post? i hope we push that out very soon after this one.

Done.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:46: performance of most programs. On the other
end, new restrictions on
On 2013/11/05 06:20:51, r wrote:
> no.
> it should have no effect at all on most programs, but for a few cases (explain
> what) it could make a big difference.

Even the release notes don't explicitly describe which cases this would benefit.
Merely that some programs would trash on stack segment switching in inner loops
(my paraphrasing). I kinda wanted to avoid getting into the technical details in
the blog post, as the link is right there.

I added a parenthetical, but I don't like it much. Can you suggest something
better?

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:60: bug reports to our dedicated contributors.
Your help is invaluable to the project.
On 2013/11/05 06:20:51, r wrote:
> maybe give some numbers?

Done.

https://codereview.appspot.com/21510045/diff/1/content/go-12-is-released.arti...
content/go-12-is-released.article:61: 
On 2013/11/05 06:20:51, r wrote:
> d

Done.

[r, 2013-11-05 06:48:04]

LGTM

https://codereview.appspot.com/21510045/diff/20001/content/go-12-is-released....
File content/go-12-is-released.article (right):

https://codereview.appspot.com/21510045/diff/20001/content/go-12-is-released....
content/go-12-is-released.article:18: We anticipate a comparable interval
between 1.2 and 1.3.
between future releases?

https://codereview.appspot.com/21510045/diff/20001/content/go-12-is-released....
content/go-12-is-released.article:38: thread, and may also yield performance
improvements in some programs.
not sure about the performance improvement claim. i can see ways in which it
might, but they're pretty obscure.

[adg, 2013-11-05 06:51:21]

https://codereview.appspot.com/21510045/diff/20001/content/go-12-is-released....
File content/go-12-is-released.article (right):

https://codereview.appspot.com/21510045/diff/20001/content/go-12-is-released....
content/go-12-is-released.article:18: We anticipate a comparable interval
between 1.2 and 1.3.
On 2013/11/05 06:48:04, r wrote:
> between future releases?

went with "future major releases"

https://codereview.appspot.com/21510045/diff/20001/content/go-12-is-released....
content/go-12-is-released.article:38: thread, and may also yield performance
improvements in some programs.
On 2013/11/05 06:48:04, r wrote:
> not sure about the performance improvement claim. i can see ways in which it
> might, but they're pretty obscure.

dropped the claim.

[adg, 2013-11-05 06:58:05]

Also re-ordered the paragraphs to mention test coverage before stack sizes and
pre-emption.

Will let this sit and commit before the release.

[adg, 2013-11-06 03:20:24]

PTAL

Added a paragraph about the playground.

[rsc, 2013-11-07 18:31:44]

LGTM

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
File content/go-12-is-released.article (right):

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
content/go-12-is-released.article:22: tools, some performance improvements, and
many additions and changes to the
s/changes/(backwards-compatible) changes/
?

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
content/go-12-is-released.article:26: the details, as some changes may affect
the behavior of existing programs.
s/existing/existing (buggy)/

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
content/go-12-is-released.article:67: `unsafe` packages inside the sandbox,
making it more like a real Go tool chain.
s/tool chain/ something else?
environment?
system?

[rsc, 2013-11-07 18:32:14]

why not just call this go12.article or go-1-2.article? i assume that will result
in a shorter URL

[adg, 2013-11-07 23:08:53]

Renamed the file to go12.article

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
File content/go-12-is-released.article (right):

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
content/go-12-is-released.article:22: tools, some performance improvements, and
many additions and changes to the
On 2013/11/07 18:31:45, rsc wrote:
> s/changes/(backwards-compatible) changes/
> ?

Done.

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
content/go-12-is-released.article:26: the details, as some changes may affect
the behavior of existing programs.
On 2013/11/07 18:31:45, rsc wrote:
> s/existing/existing (buggy)/

Done.

https://codereview.appspot.com/21510045/diff/100001/content/go-12-is-released...
content/go-12-is-released.article:67: `unsafe` packages inside the sandbox,
making it more like a real Go tool chain.
On 2013/11/07 18:31:45, rsc wrote:
> s/tool chain/ something else?
> environment?
> system?

environment

[adg, 2013-12-01 21:44:47]

*** Submitted as
https://code.google.com/p/go/source/detail?r=be91936ec202&repo=blog ***

go.blog: add Go 1.2 release article

R=r, iant, rsc
https://codereview.appspot.com/21510045