Issue 215050: code review 215050: godoc: path cleanups, fixed a race condition, initial s...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 215050: code review 215050: godoc: path cleanups, fixed a race condition, initial s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by gri

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, adg, golang-dev

Visibility:
Public.

Description

godoc: path cleanups, fixed a race condition, initial support for a menu on pages

Patch Set 1 #

Patch Set 2 : code review 215050: godoc: path cleanups, fixed a race condition, initial s... #

Patch Set 3 : code review 215050: godoc: path cleanups, fixed a race condition, initial s... #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -36 lines)			Patch
M	doc/style.css	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	lib/godoc/godoc.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/cmd/godoc/doc.go	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View	1	10 chunks	+14 lines, -27 lines	0 comments	Download
M	src/cmd/godoc/main.go	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: adg, golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-18 23:09:24 UTC) #1

gri

15 years, 1 month ago (2010-02-19 01:40:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=798161df66ad ***

godoc: path cleanups, fixed a race condition, initial support for a menu on
pages

R=rsc
CC=adg, golang-dev
http://codereview.appspot.com/215050

Expand All Messages | Collapse All Messages