Issue 214050: code review 214050: more complex - constants

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 214050: code review 214050: more complex - constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by ken3

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

more complex - constants import and export

Patch Set 1 #

Patch Set 2 : code review 214050: more complex - constants #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -3 lines)			Patch
M	src/cmd/gc/const.c	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/cmd/gc/export.c	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/go.y	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/type.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-18 22:46:27 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=c5f3491b5768 *** more complex - constants import and export R=rsc CC=golang-dev http://codereview.appspot.com/214050

15 years, 1 month ago (2010-02-18 22:46:37 UTC) #2

LGTM

Expand All Messages | Collapse All Messages