LGTM
Hello adg, rsc1 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
*** Submitted as http://code.google.com/p/go/source/detail?r=3e3126063f68 *** crypto/tls: don't return an error from Close() Fixes issue 1037. R=adg, rsc1 CC=golang-dev http://codereview.appspot.com/2107048
LGTM On 11 September 2010 04:43, <agl@golang.org> wrote: > Reviewers: adg, > > Description: > crypto/tls: don't return an error from Close() > > Fixes issue 1037. > > Please review this at http://codereview.appspot.com/2107048/ > > Affected files: > M src/pkg/crypto/tls/conn.go > > > Index: src/pkg/crypto/tls/conn.go > =================================================================== > --- a/src/pkg/crypto/tls/conn.go > +++ b/src/pkg/crypto/tls/conn.go > @@ -445,7 +445,11 @@ > } > c.tmp[1] = byte(err) > c.writeRecord(recordTypeAlert, c.tmp[0:2]) > - return c.setError(&net.OpError{Op: "local error", Error: err}) > + // closeNotify is a special case in that it isn't an error: > + if err != alertCloseNotify { > + return c.setError(&net.OpError{Op: "local error", Error: > err}) > + } > + return nil > } > > // sendAlert sends a TLS alert message. > > >