Issue 20570044: code review 20570044: [release-branch.go1.2] strings: fix Replacer bug with p...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20570044: code review 20570044: [release-branch.go1.2] strings: fix Replacer bug with p... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adg

Modified:
10 years, 6 months ago

Reviewers:
dsymonds

CC:
golang-dev

Visibility:
Public.

Description

[release-branch.go1.2] strings: fix Replacer bug with prefix matches ««« CL 16880043 / 0eb6508d3e88 strings: fix Replacer bug with prefix matches singleStringReplacer had a bug where if a string was replaced at the beginning and no output had yet been produced into the temp buffer before matching ended, an invalid nil check (used as a proxy for having matched anything) meant it always returned its input. Fixes issue 6659 R=golang-dev, r CC=golang-dev https://codereview.appspot.com/16880043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 220dfbb528c6 https://code.google.com/p/go #

Patch Set 3 : diff -r 220dfbb528c6 https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	src/pkg/strings/replace.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	src/pkg/strings/replace_test.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-11-01 00:18:34 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=0883b7d7a008 *** [release-branch.go1.2] strings: fix Replacer bug with prefix matches ««« CL ...

10 years, 6 months ago (2013-11-01 00:18:57 UTC) #2

LGTM

Expand All Messages | Collapse All Messages