Issue 20540043: code review 20540043: [release-branch.go1.2] runtime: remove nomemprof

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20540043: code review 20540043: [release-branch.go1.2] runtime: remove nomemprof (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adg

Modified:
10 years, 6 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

[release-branch.go1.2] runtime: remove nomemprof ««« CL 14695044 / 35d5bae6aac8 runtime: remove nomemprof Nomemprof seems to be unneeded now, there is no recursion. If the recursion will be re-introduced, it will break loudly by deadlocking. Fixes issue 6566. R=golang-dev, minux.ma, rsc CC=golang-dev https://codereview.appspot.com/14695044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 8f428c6be9fd https://code.google.com/p/go #

Patch Set 3 : diff -r 8f428c6be9fd https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -13 lines)			Patch
M	src/pkg/runtime/mprof.goc	View	1	4 chunks	+0 lines, -10 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-31 23:50:51 UTC) #1

adg

10 years, 6 months ago (2013-10-31 23:51:53 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=26de80888166 ***

[release-branch.go1.2] runtime: remove nomemprof

««« CL 14695044 / 35d5bae6aac8
runtime: remove nomemprof
Nomemprof seems to be unneeded now, there is no recursion.
If the recursion will be re-introduced, it will break loudly by deadlocking.
Fixes issue 6566.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/14695044
»»»

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/20540043

Expand All Messages | Collapse All Messages