Issue 205044: code review 205044: Struct field ambiguity test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 205044: code review 205044: Struct field ambiguity test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by iant

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Struct field ambiguity test. gccgo gets this wrong at the moment.

Patch Set 1 #

Patch Set 2 : code review 205044: Struct field ambiguity test. #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	A	test/fixedbugs/bug253.go	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-08 22:40:31 UTC) #1

rsc

LGTM maybe add a comment on the != 0 check: // .i refers to s4.S1.i, ...

15 years, 1 month ago (2010-02-08 22:42:05 UTC) #2

iant

15 years, 1 month ago (2010-02-08 23:40:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=80c337c288b3 ***

Struct field ambiguity test.

gccgo gets this wrong at the moment.

R=rsc
CC=golang-dev
http://codereview.appspot.com/205044

Expand All Messages | Collapse All Messages