Issue 205042: code review 205042: Fix *l/*c -V flag segfault

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 205042: code review 205042: Fix l/c -V flag segfault (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by dpx

Modified:
15 years, 1 month ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

Fix *l/*c -V flag segfault *l/*c -V will segfault on macos without this trivial fix.

Patch Set 1 #

Patch Set 2 : code review 205042: Fix l/c -V flag segfault #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	include/libc.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dpx

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-08 19:41:30 UTC) #1

adg

LGTM. Good catch. Thanks. On 2010/02/08 19:41:30, dpx wrote: > Hello adg (cc: mailto:golang-dev@googlegroups.com), > ...

15 years, 1 month ago (2010-02-08 19:47:38 UTC) #2

adg

On 8 February 2010 11:41, <dean.prichard@gmail.com> wrote: > *l/*c -V will segfault on macos without ...

15 years, 1 month ago (2010-02-08 19:49:03 UTC) #3

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=8bb0174f3bcd *** Fix *l/*c -V flag segfault *l/*c -V will segfault on ...

15 years, 1 month ago (2010-02-08 19:53:31 UTC) #4

dpx

15 years, 1 month ago (2010-02-08 19:58:37 UTC) #5

I've got osx 10.6

On Mon, Feb 8, 2010 at 12:49 PM, Andrew Gerrand <adg@golang.org> wrote:

> On 8 February 2010 11:41,  <dean.prichard@gmail.com> wrote:
> > *l/*c -V will segfault on macos without this trivial fix.
>
> Can I ask what version of OSX you're running? I made the original
> change under Leopard and didn't experience any issues.
>
> Andrew
>

Expand All Messages | Collapse All Messages