Issue 204065: code review 204065: runtime: allow arbitrary return type in SetFinalizer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 204065: code review 204065: runtime: allow arbitrary return type in SetFinalizer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by rsc

Modified:
15 years, 1 month ago

Reviewers:
ken3, cw

CC:
ken2, golang-dev

Visibility:
Public.

Description

runtime: allow arbitrary return type in SetFinalizer. finalize chan, to free OS X semaphore inside Lock. os: finalize File, to close fd. Fixes issue 503.

Patch Set 2 : code review 204065: runtime: allow arbitrary return type in SetFinalizer. #

Total comments: 1

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -37 lines)			Patch
M	src/pkg/os/file.go	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/chan.c	View	1	3 chunks	+9 lines, -0 lines	1 comment	Download
M	src/pkg/runtime/darwin/thread.c	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/freebsd/thread.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/thread.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/malloc.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/malloc.cgo	View		3 chunks	+15 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/mfinal.c	View	1	5 chunks	+18 lines, -11 lines	0 comments	Download
M	src/pkg/runtime/mgc0.c	View		5 chunks	+23 lines, -11 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View		2 chunks	+10 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-09 05:41:53 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=b45e8d6389ae *** runtime: allow arbitrary return type in SetFinalizer. finalize chan, to ...

15 years, 1 month ago (2010-02-09 05:41:57 UTC) #2

http://codereview.appspot.com/204065/diff/2001/3002 File src/pkg/runtime/chan.c (right): http://codereview.appspot.com/204065/diff/2001/3002#newcode103 src/pkg/runtime/chan.c:103: addfinalizer(c, destroychan, 0); is there a clean way to ...

15 years, 1 month ago (2010-02-09 05:50:19 UTC) #3

ken3

15 years, 1 month ago (2010-02-10 01:55:23 UTC) #4

LGTM

On 2010/02/09 05:50:19, cw wrote:
> http://codereview.appspot.com/204065/diff/2001/3002
> File src/pkg/runtime/chan.c (right):
> 
> http://codereview.appspot.com/204065/diff/2001/3002#newcode103
> src/pkg/runtime/chan.c:103: addfinalizer(c, destroychan, 0);
> is there a clean way to do this for darwin only?  it seems pointless to have
the
> empty stub functions in freebsd and linux

Expand All Messages | Collapse All Messages