Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(310)

Issue 20170048: code review 20170048: [release-branch.go1.2] cmd/5l, runtime: fix divide for ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by adg
Modified:
9 years, 10 months ago
Reviewers:
gobot, dsymonds
CC:
golang-dev
Visibility:
Public.

Description

[release-branch.go1.2] cmd/5l, runtime: fix divide for profiling tracebacks on ARM ««« CL 19910044 / 9eb64f5ef3a6 cmd/5l, runtime: fix divide for profiling tracebacks on ARM Two bugs: 1. The first iteration of the traceback always uses LR when provided, which it is (only) during a profiling signal, but in fact LR is correct only if the stack frame has not been allocated yet. Otherwise an intervening call may have changed LR, and the saved copy in the stack frame should be used. Fix in traceback_arm.c. 2. The division runtime call adds 8 bytes to the stack. In order to keep the traceback routines happy, it must copy the saved LR into the new 0(SP). Change SUB $8, SP into MOVW 0(SP), R11 // r11 is temporary, for use by linker MOVW.W R11, -8(SP) to update SP and 0(SP) atomically, so that the traceback always sees a saved LR at 0(SP). Fixes issue 6681. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/19910044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 2208cab27e8f https://code.google.com/p/go #

Patch Set 3 : diff -r 2208cab27e8f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -6 lines) Patch
M src/cmd/5l/noop.c View 1 1 chunk +18 lines, -5 lines 0 comments Download
M src/pkg/runtime/pprof/pprof_test.go View 1 3 chunks +25 lines, -0 lines 0 comments Download
M src/pkg/runtime/traceback_arm.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 5 months ago (2013-11-01 00:34:24 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=29d07b807b75 *** [release-branch.go1.2] cmd/5l, runtime: fix divide for profiling tracebacks on ARM ...
10 years, 5 months ago (2013-11-01 00:34:47 UTC) #2
dsymonds
LGTM
10 years, 5 months ago (2013-11-01 00:34:50 UTC) #3
gobot
9 years, 10 months ago (2014-05-28 20:05:15 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64 builder.
See http://build.golang.org/log/9fbd16c040e8351a9b2a53ff7f2a886d6024dcac
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b