Issue 2015043: code review 2015043: gc: fix parenthesization check

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2015043: code review 2015043: gc: fix parenthesization check (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by rsc

Modified:
14 years, 8 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: fix parenthesization check Cannot use paren field in Node because all instances of a given symbol name use the same Node. Fixes issue 1022.

Patch Set 1 #

Patch Set 2 : code review 2015043: gc: fix parenthesization check #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -16 lines)			Patch
M	src/cmd/gc/go.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/go.y	View	7 chunks	+20 lines, -15 lines	0 comments	Download
M	src/cmd/gc/print.c	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-08-24 03:10:22 UTC) #1

rsc

14 years, 8 months ago (2010-08-24 03:10:32 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=36cb646b1790 ***

gc: fix parenthesization check

Cannot use paren field in Node because all
instances of a given symbol name use the same Node.

Fixes issue 1022.

R=ken2
CC=golang-dev
http://codereview.appspot.com/2015043

Expand All Messages | Collapse All Messages