Issue 2012041: code review 2012041: run.bash: fix freebsd build (i hope)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2012041: code review 2012041: run.bash: fix freebsd build (i hope) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by rsc

Modified:
14 years, 8 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

run.bash: fix freebsd build (i hope)

Patch Set 1 #

Patch Set 2 : code review 2012041: run.bash: fix freebsd build (i hope) #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/run.bash	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-08-18 14:22:54 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=54b874b5978e *** run.bash: fix freebsd build (i hope) R=adg CC=golang-dev http://codereview.appspot.com/2012041

14 years, 8 months ago (2010-08-18 14:23:03 UTC) #2

adg

14 years, 8 months ago (2010-08-19 05:09:18 UTC) #3

LGTM

On 19 August 2010 00:22,  <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> run.bash: fix freebsd build (i hope)
>
> Please review this at http://codereview.appspot.com/2012041/
>
> Affected files:
>  M src/run.bash
>
>
> Index: src/run.bash
> ===================================================================
> --- a/src/run.bash
> +++ b/src/run.bash
> @@ -6,6 +6,7 @@
>  set -e
>  . ./env.bash
>
> +unset MAKEFLAGS  # single-threaded make
>  unset CDPATH   # in case user has it set
>
>  # no core files, please
>
>
>

Expand All Messages | Collapse All Messages