code review 20100043: misc/emacs: various cleanups

misc/emacs: various cleanups

- Use #' for function symbols
- Remove unused variables
- Use declare-function to shut up byte compiler

This is identical to CL 19010044 with one exception: Making sure
it doesn't break on Emacs 22.1

[Dominik Honnef, 2013-10-31 00:52:18]

Hello adonovan@google.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[Dominik Honnef, 2013-10-31 00:52:59]

Brad, please check that this does in fact work in Emacs 22.1 – I don't have
access to that version.

[shendaras_gmail.com, 2013-10-31 01:54:08]

I may be off base because I don't write much Emacs Lisp.  When writing
something like 'symbol we are essentially doing (quote symbol). When
writing #'symbol, we are doing (function symbol). For the calls to fboundp,
shouldn't we just be using the quote form instead?
On Oct 30, 2013 7:53 PM, <dominik.honnef@gmail.com> wrote:

> Brad, please check that this does in fact work in Emacs 22.1 – I don't
> have access to that version.
>
>
https://codereview.appspot.**com/20100043/<https://codereview.appspot.com/201...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[Dominik Honnef, 2013-10-31 01:58:20]

This iteration of the CL does use quote for the fboundp calls, doesn't it?
`(fboundp 'kill-whole-line)` and `(fboundp 'position-bytes)`. Did I mess it up
somewhere else?

On 2013/10/31 01:54:08, shendaras_gmail.com wrote:
> I may be off base because I don't write much Emacs Lisp.  When writing
> something like 'symbol we are essentially doing (quote symbol). When
> writing #'symbol, we are doing (function symbol). For the calls to fboundp,
> shouldn't we just be using the quote form instead?
> On Oct 30, 2013 7:53 PM, <mailto:dominik.honnef@gmail.com> wrote:
> 
> > Brad, please check that this does in fact work in Emacs 22.1 – I don't
> > have access to that version.
> >
> >
>
https://codereview.appspot.**com/20100043/%3Chttps://codereview.appspot.com/2...>
> >
> > --
> >
> > ---You received this message because you are subscribed to the Google
> > Groups "golang-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to
>
mailto:golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
> > .
> > For more options, visit
>
https://groups.google.com/**groups/opt_out%3Chttps://groups.google.com/groups...>
> > .
> >

[adonovan, 2013-10-31 02:04:32]

On 30 October 2013 21:54, Daniel Barrett <shendaras@gmail.com> wrote:

> I may be off base because I don't write much Emacs Lisp.  When writing
> something like 'symbol we are essentially doing (quote symbol). When
> writing #'symbol, we are doing (function symbol). For the calls to fboundp,
> shouldn't we just be using the quote form instead?
>

You are correct.  As I mentioned in the review for the CL that introduced
#' quotations, Emacs Lisp is actually very forgiving of using the wrong
quote operator.  (Most elisp code uses 'f when Common Lisp would require
#'f.  The only downside, other than readability to speakers of Common Lisp,
is a slight deoptimization.)

[shendaras_gmail.com, 2013-10-31 02:18:48]

Alan, thank you for the info. I apparently need to get some reading glasses
as you are correct for the fboundp calls only having '. I don't know about
some of the macros and things, but if Emacs doesn't really care there's no
need to be pedantic. I was mostly curious.
On Oct 30, 2013 9:04 PM, "Alan Donovan" <adonovan@google.com> wrote:

> On 30 October 2013 21:54, Daniel Barrett <shendaras@gmail.com> wrote:
>
>> I may be off base because I don't write much Emacs Lisp.  When writing
>> something like 'symbol we are essentially doing (quote symbol). When
>> writing #'symbol, we are doing (function symbol). For the calls to fboundp,
>> shouldn't we just be using the quote form instead?
>>
>
> You are correct.  As I mentioned in the review for the CL that introduced
> #' quotations, Emacs Lisp is actually very forgiving of using the wrong
> quote operator.  (Most elisp code uses 'f when Common Lisp would require
> #'f.  The only downside, other than readability to speakers of Common Lisp,
> is a slight deoptimization.)
>

[bradfitz, 2013-11-01 20:05:55]

LGTM (in that it works for me)


On Wed, Oct 30, 2013 at 5:53 PM, <dominik.honnef@gmail.com> wrote:

> Brad, please check that this does in fact work in Emacs 22.1 – I don't
> have access to that version.
>

Sorry for the delay. Computer problems.

Seems to work.  Thanks!

[adonovan, 2013-11-08 20:23:09]

On 2013/11/01 20:05:55, bradfitz wrote:
> LGTM (in that it works for me)
> 
> 
> On Wed, Oct 30, 2013 at 5:53 PM, <mailto:dominik.honnef@gmail.com> wrote:
> 
> > Brad, please check that this does in fact work in Emacs 22.1 – I don't
> > have access to that version.
> >
> 
> Sorry for the delay. Computer problems.
> 
> Seems to work.  Thanks!

LGTM, submitting presently.

(Sorry for the slow response; never be afraid to ping me.)

[adonovan, 2013-11-08 20:23:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=9fe43a708b89 ***

misc/emacs: various cleanups

- Use #' for function symbols
- Remove unused variables
- Use declare-function to shut up byte compiler

This is identical to CL 19010044 with one exception: Making sure
it doesn't break on Emacs 22.1

R=adonovan, bradfitz, shendaras
CC=golang-dev
https://codereview.appspot.com/20100043

Committer: Alan Donovan <adonovan@google.com>

[Dominik Honnef, 2013-11-08 20:24:20]

On 2013/11/08 20:23:09, adonovan wrote:
> On 2013/11/01 20:05:55, bradfitz wrote:
> > LGTM (in that it works for me)
> > 
> > 
> > On Wed, Oct 30, 2013 at 5:53 PM, <mailto:dominik.honnef@gmail.com> wrote:
> > 
> > > Brad, please check that this does in fact work in Emacs 22.1 – I don't
> > > have access to that version.
> > >
> > 
> > Sorry for the delay. Computer problems.
> > 
> > Seems to work.  Thanks!
> 
> LGTM, submitting presently.
> 
> (Sorry for the slow response; never be afraid to ping me.)

Didn't ping because of the freeze :/

[bradfitz, 2013-11-08 20:27:25]

Alan didn't know about the freeze.

But I think everybody does now.

This is probably okay.



On Fri, Nov 8, 2013 at 3:24 PM, <dominik.honnef@gmail.com> wrote:

> On 2013/11/08 20:23:09, adonovan wrote:
>
>> On 2013/11/01 20:05:55, bradfitz wrote:
>> > LGTM (in that it works for me)
>> >
>> >
>> > On Wed, Oct 30, 2013 at 5:53 PM, <mailto:dominik.honnef@gmail.com>
>>
> wrote:
>
>> >
>> > > Brad, please check that this does in fact work in Emacs 22.1 – I
>>
> don't
>
>> > > have access to that version.
>> > >
>> >
>> > Sorry for the delay. Computer problems.
>> >
>> > Seems to work.  Thanks!
>>
>
>  LGTM, submitting presently.
>>
>
>  (Sorry for the slow response; never be afraid to ping me.)
>>
>
> Didn't ping because of the freeze :/
>
> https://codereview.appspot.com/20100043/
>