Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 20050045: code review 20050045: [release-branch.go1.2] time: fix ParseDuration overflow... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by adg
Modified:
10 years, 5 months ago
Reviewers:
dsymonds
CC:
golang-dev
Visibility:
Public.

Description

[release-branch.go1.2] time: fix ParseDuration overflow when given more than 9 digits on 32-bit arch ««« CL 15080043 / fbf3b853e00b time: fix ParseDuration overflow when given more than 9 digits on 32-bit arch Fixes issue 6617. R=golang-dev, rsc, r CC=golang-dev https://codereview.appspot.com/15080043 Committer: Russ Cox <rsc@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 4876f5dc808b https://code.google.com/p/go #

Patch Set 3 : diff -r 4876f5dc808b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/pkg/time/format.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/time/time_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 5 months ago (2013-11-01 00:13:00 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=2d7e5747d2df *** [release-branch.go1.2] time: fix ParseDuration overflow when given more than 9 ...
10 years, 5 months ago (2013-11-01 00:13:39 UTC) #2
dsymonds
10 years, 5 months ago (2013-11-01 00:15:45 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b