Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3095)

Issue 19940044: code review 19940044: go.net/ipv6: implement getsockopt, setsockopt syscalls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by mikio
Modified:
10 years, 4 months ago
Reviewers:
dsymonds, dfc
CC:
dfc, dsymonds, adg, golang-dev
Visibility:
Public.

Description

go.net/ipv6: implement getsockopt, setsockopt syscalls This CL implements a part of syscall package that's not included in Go 1.1 release for not to annoy people who need some package in go.net sub repository with Go 1.1. Update issue 6548

Patch Set 1 #

Patch Set 2 : diff -r 67397a11592e https://code.google.com/p/go.net #

Patch Set 3 : diff -r 67397a11592e https://code.google.com/p/go.net #

Patch Set 4 : diff -r 7d357a8fe6f0 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -0 lines) Patch
A ipv6/sys.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
A ipv6/sys_bsd.go View 1 1 chunk +48 lines, -0 lines 0 comments Download
A ipv6/sys_darwin.go View 1 1 chunk +54 lines, -0 lines 0 comments Download
A ipv6/sys_linux.go View 1 1 chunk +45 lines, -0 lines 0 comments Download
A ipv6/sys_unix.go View 1 1 chunk +16 lines, -0 lines 0 comments Download
A ipv6/sys_windows.go View 1 1 chunk +33 lines, -0 lines 0 comments Download
A ipv6/syscall_linux_386.go View 1 1 chunk +42 lines, -0 lines 0 comments Download
A ipv6/syscall_linux_386.s View 1 1 chunk +56 lines, -0 lines 0 comments Download
A ipv6/syscall_nosplit4_linux_386.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
A ipv6/syscall_nosplit7_linux_386.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
A ipv6/syscall_unix.go View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 9
mikio
Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
10 years, 4 months ago (2013-11-02 23:48:53 UTC) #1
dfc
This looks reasonable to me, thank you for making it work on 1.1, hopefully this ...
10 years, 4 months ago (2013-11-03 07:52:16 UTC) #2
dsymonds
This approach LGTM. You have misspelled "people" in the CL description.
10 years, 4 months ago (2013-11-03 22:14:35 UTC) #3
mikio
On Mon, Nov 4, 2013 at 7:14 AM, <dsymonds@golang.org> wrote: > You have misspelled "people" ...
10 years, 4 months ago (2013-11-04 00:18:00 UTC) #4
dfc
Are these errors expected ? 220887(~/src/code.google.com/p/go.net) % gb ./... code.google.com/p/go.net/ipv6 # code.google.com/p/go.net/ipv6 ipv6/control_rfc3542_linux.go:83: undefined: syscall.SizeofIPv6MTUInfo ...
10 years, 4 months ago (2013-11-04 00:39:07 UTC) #5
mikio
On Mon, Nov 4, 2013 at 9:39 AM, <dave@cheney.net> wrote: > Are these errors expected ...
10 years, 4 months ago (2013-11-04 01:31:53 UTC) #6
dfc
On 2013/11/04 01:31:53, mikio wrote: > On Mon, Nov 4, 2013 at 9:39 AM, <mailto:dave@cheney.net> ...
10 years, 4 months ago (2013-11-04 04:29:31 UTC) #7
mikio
I see, thanks for the explanation. Yup, we need the next one that smashes all ...
10 years, 4 months ago (2013-11-05 01:08:15 UTC) #8
mikio
10 years, 4 months ago (2013-11-05 01:09:48 UTC) #9
*** Submitted as
https://code.google.com/p/go/source/detail?r=6aba239cf27b&repo=net ***

go.net/ipv6: implement getsockopt, setsockopt syscalls

This CL implements a part of syscall package that's not included
in Go 1.1 release for not to annoy people who need some package
in go.net sub repository with Go 1.1.

Update issue 6548

R=dave, dsymonds, adg
CC=golang-dev
https://codereview.appspot.com/19940044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b