code review 19850048: [release-branch.go1.2] cmd/cgo: stop using -fno-elimina...

[release-branch.go1.2] cmd/cgo: stop using -fno-eliminate-unused-debug-types

««« CL 18850043 / 5ef4bf9eb256
cmd/cgo: stop using -fno-eliminate-unused-debug-types

This flag was added in January 2010, in CL 181102, to fix issue 497.
(Numbers were just shorter back then.) The fix was for OS X machines
and the llvm-gcc frontend.

In July 2011 we had to change the way we get enum values, because
there were no flags available to force Xcode's llvm-gcc to include the
enum names and values in DWARF debug output.

We now use clang, not llvm-gcc, on OS X machines.
Earlier versions of clang printed a warning about not knowing the flag.
Newer versions of clang now make that an error.

That is:
 - The flag was added for OS X machines.
 - The flag is no longer necessary on OS X machines.
 - The flag now breaks some OS X machines.

Remove it.

I have run the original program from issue 497 successfully
without the flag on both OS X and Linux machines.

Fixes issue 6678.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/18850043
»»»

[adg, 2013-11-01 00:22:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2013-11-01 00:22:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=6f62370a69e3 ***

[release-branch.go1.2] cmd/cgo: stop using -fno-eliminate-unused-debug-types

««« CL 18850043 / 5ef4bf9eb256
cmd/cgo: stop using -fno-eliminate-unused-debug-types

This flag was added in January 2010, in CL 181102, to fix issue 497.
(Numbers were just shorter back then.) The fix was for OS X machines
and the llvm-gcc frontend.

In July 2011 we had to change the way we get enum values, because
there were no flags available to force Xcode's llvm-gcc to include the
enum names and values in DWARF debug output.

We now use clang, not llvm-gcc, on OS X machines.
Earlier versions of clang printed a warning about not knowing the flag.
Newer versions of clang now make that an error.

That is:
 - The flag was added for OS X machines.
 - The flag is no longer necessary on OS X machines.
 - The flag now breaks some OS X machines.

Remove it.

I have run the original program from issue 497 successfully
without the flag on both OS X and Linux machines.

Fixes issue 6678.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/18850043
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/19850048

[dsymonds, 2013-11-01 00:23:12]

LGTM