Issue 197044: code review 197044: gc: ... T corner cases

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 197044: code review 197044: gc: ... T corner cases (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by rsc

Modified:
15 years, 1 month ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: ... T corner cases more to come, but should suffice for Printf work.

Patch Set 1 #

Patch Set 2 : code review 197044: gc: ... T corner cases #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -5 lines)			Patch
M	src/cmd/gc/closure.c	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/cmd/gc/dcl.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/ddd.go	View	4 chunks	+66 lines, -0 lines	0 comments	Download
M	test/ddd1.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-01 18:49:22 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=1bec7ad29e8a *** gc: ... T corner cases more to come, but should ...

15 years, 1 month ago (2010-02-01 18:49:27 UTC) #2

ken3

15 years, 1 month ago (2010-02-01 19:07:54 UTC) #3

LGTM

On 2010/02/01 18:49:27, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=1bec7ad29e8a ***
> 
> gc: ... T corner cases
> 
> more to come, but should suffice for Printf work.
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/197044

Expand All Messages | Collapse All Messages