Issue 197043: code review 197043: Change type of Printf's args to ... interface{}

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 197043: code review 197043: Change type of Printf's args to ... interface{} (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by r

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Change type of Printf's args to ... interface{}

Patch Set 1 #

Patch Set 2 : code review 197043: Change type of Printf's args to ... interface{} #

Patch Set 3 : code review 197043: Change type of Printf's args to ... interface{} #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+248 lines, -141 lines)			Patch
M	src/cmd/cgo/util.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/goyacc/goyacc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/debug/proc/proc_linux.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/eval/compiler.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/eval/expr.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/eval/stmt.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/parser/parser.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/fmt/print.go	View	1	22 chunks	+205 lines, -96 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/printer.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/log/log.go	View	1	1 chunk	+12 lines, -10 lines	0 comments	Download
M	src/pkg/template/template.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/testing/testing.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	test/bench/pidigits.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/defer.go	View		3 chunks	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-01 23:14:49 UTC) #1

15 years, 1 month ago (2010-02-01 23:53:41 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8135867e435d ***

Change type of Printf's args to ... interface{}

R=rsc
CC=golang-dev
http://codereview.appspot.com/197043