Issue 196890043: code review 196890043: go-tour: improve existing solution for binarytrees.go a...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 196890043: code review 196890043: go-tour: improve existing solution for binarytrees.go a... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by francesc

Modified:
9 years, 3 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

go-tour: improve existing solution for binarytrees.go and add non leaky solution

Patch Set 2 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Patch Set 4 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Patch Set 5 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Total comments: 6

Patch Set 6 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Patch Set 7 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Patch Set 8 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Patch Set 9 : diff -r d1a4f15924590a381a341d981bfeb11aae9b3b19 https://code.google.com/p/go-tour #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -10 lines)			Patch
	M	solutions/binarytrees.go	View	1	3 chunks	+10 lines, -10 lines	0 comments	Download
	A	solutions/binarytrees_quit.go	View	1 2 3 4 5	1 chunk	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 3 months ago (2015-01-16 17:39:19 UTC) #1

adg

LGTM https://codereview.appspot.com/196890043/diff/40002/solutions/binarytrees_quit.go File solutions/binarytrees_quit.go (right): https://codereview.appspot.com/196890043/diff/40002/solutions/binarytrees_quit.go#newcode22 solutions/binarytrees_quit.go:22: // Value successfully sent. indent https://codereview.appspot.com/196890043/diff/40002/solutions/binarytrees_quit.go#newcode24 solutions/binarytrees_quit.go:24: // ...

9 years, 3 months ago (2015-01-18 23:12:28 UTC) #2

francesc

9 years, 3 months ago (2015-01-20 19:45:47 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=c37841cbdac8
***

go-tour: improve existing solution for binarytrees.go and add non leaky solution

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/196890043

https://codereview.appspot.com/196890043/diff/40002/solutions/binarytrees_qui...
File solutions/binarytrees_quit.go (right):

https://codereview.appspot.com/196890043/diff/40002/solutions/binarytrees_qui...
solutions/binarytrees_quit.go:22: // Value successfully sent.
On 2015/01/18 23:12:28, adg wrote:
> indent

Done.

https://codereview.appspot.com/196890043/diff/40002/solutions/binarytrees_qui...
solutions/binarytrees_quit.go:24: // Iteration stopped by the consumer.
On 2015/01/18 23:12:28, adg wrote:
> delete

Done.

https://codereview.appspot.com/196890043/diff/40002/solutions/binarytrees_qui...
solutions/binarytrees_quit.go:34: // Need to close the channel here
On 2015/01/18 23:12:28, adg wrote:
> delete

Done.

Expand All Messages | Collapse All Messages