Issue 196090: code review 196090: Add RFC822 formats as named constants.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 196090: code review 196090: Add RFC822 formats as named constants. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by r

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Add RFC822 formats as named constants. Make sure to print a time zone when formatting even if none is defined. Add a comment introducing lookupTimezone (not lookupTimeZone). Fixes isse 577.

Patch Set 1 #

Patch Set 2 : code review 196090: Add RFC822 formats as named constants. #

Patch Set 3 : code review 196090: Add RFC822 formats as named constants. #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -5 lines)			Patch
M	src/pkg/time/format.go	View	1	3 chunks	+22 lines, -5 lines	0 comments	Download
M	src/pkg/time/time_test.go	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/pkg/time/zoneinfo.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

I think a longer CL description would be useful. Does rfc2822 have any relevant differences ...

14 years, 2 months ago (2010-02-04 01:46:55 UTC) #1

?? i haven't sent this out for review. -rob On Feb 4, 2010, at 12:46 ...

14 years, 2 months ago (2010-02-04 01:48:04 UTC) #2

On Thu, Feb 04, 2010 at 12:47:50PM +1100, Rob 'Commander' Pike wrote: > ?? i ...

14 years, 2 months ago (2010-02-04 01:53:17 UTC) #3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2010-02-04 04:29:30 UTC) #4

14 years, 2 months ago (2010-02-04 04:39:32 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=82d16d8092f5 ***

Add RFC822 formats as named constants.
Make sure to print a time zone when formatting even if none is defined.
Add a comment introducing lookupTimezone (not lookupTimeZone).

Fixes isse 577.

R=rsc
CC=golang-dev
http://codereview.appspot.com/196090

Expand All Messages | Collapse All Messages