Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3518)

Issue 1960042: code review 1960042: 6g, 8g: handle slice by sub-word-sized index (uint8, in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by rsc
Modified:
13 years, 7 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

6g, 8g: handle slice by sub-word-sized index (uint8, int8, uint16, int16)

Patch Set 1 #

Patch Set 2 : code review 1960042: 6g, 8g: handle slice by sub-word-sized index (uint8, in... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -16 lines) Patch
M src/cmd/6g/ggen.c View 1 chunk +9 lines, -7 lines 0 comments Download
M src/cmd/8g/ggen.c View 4 chunks +26 lines, -5 lines 0 comments Download
M src/pkg/exp/draw/x11/auth.go View 1 chunk +1 line, -4 lines 0 comments Download
A test/fixedbugs/bug303.go View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 7 months ago (2010-08-12 05:27:46 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=a16884829031 *** 6g, 8g: handle slice by sub-word-sized index (uint8, int8, uint16, ...
13 years, 7 months ago (2010-08-12 05:27:49 UTC) #2
ken3
13 years, 7 months ago (2010-08-12 12:43:39 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b