Issue 19600043: code review 19600043: doc/go1.2.html: stack sizes, thread limits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 19600043: code review 19600043: doc/go1.2.html: stack sizes, thread limits (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by r

Modified:
10 years, 6 months ago

Reviewers:
rsc

CC:
golang-dev, minux1, adg, rsc

Visibility:
Public.

Description

doc/go1.2.html: stack sizes, thread limits

Patch Set 2 : diff -r dbcd720e5396 https://code.google.com/p/go #

Total comments: 4

Patch Set 3 : diff -r 8b49cdda6ff4 https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	doc/go1.2.html	View	1 2	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-29 23:41:29 UTC) #1

minux1

i'm replying from phone. both new API mentioned are in runtime/debug (unintuitive, i think), not ...

10 years, 6 months ago (2013-10-29 23:49:53 UTC) #2

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 6 months ago (2013-10-29 23:51:06 UTC) #3

adg

https://codereview.appspot.com/19600043/diff/20001/doc/go1.2.html File doc/go1.2.html (right): https://codereview.appspot.com/19600043/diff/20001/doc/go1.2.html#newcode143 doc/go1.2.html:143: Go 1.2 introduces a configurable limit (default 10,000) to ...

10 years, 6 months ago (2013-10-30 00:09:56 UTC) #4

rsc

LGTM https://codereview.appspot.com/19600043/diff/20001/doc/go1.2.html File doc/go1.2.html (right): https://codereview.appspot.com/19600043/diff/20001/doc/go1.2.html#newcode143 doc/go1.2.html:143: Go 1.2 introduces a configurable limit (default 10,000) ...

10 years, 6 months ago (2013-10-30 12:39:48 UTC) #5

10 years, 6 months ago (2013-10-30 15:54:57 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=746466b52725 ***

doc/go1.2.html: stack sizes, thread limits

R=golang-dev, minux.ma, adg, rsc
CC=golang-dev
https://codereview.appspot.com/19600043

Expand All Messages | Collapse All Messages