Issue 194053: code review 194053: runtime, type switch: eliminate package global name spa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194053: code review 194053: runtime, type switch: eliminate package global name spa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

runtime, type switch: eliminate package global name space assumption bonus: type switch now detects multiple uses of identical interface types. bonus: interface types are now order-independent, following the spec.

Patch Set 1 #

Patch Set 2 : code review 194053: runtime, type switch: eliminate package global name spa... #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+424 lines, -168 lines)			Patch
M	src/cmd/gc/go.h	View		4 chunks	+3 lines, -13 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View		8 chunks	+38 lines, -33 lines	0 comments	Download
M	src/cmd/gc/subr.c	View		8 chunks	+52 lines, -37 lines	0 comments	Download
M	src/cmd/gc/swt.c	View		6 chunks	+98 lines, -67 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/reflect/type.go	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	src/pkg/reflect/value.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/iface.c	View		4 chunks	+7 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/type.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	src/pkg/runtime/type.go	View		2 chunks	+2 lines, -4 lines	0 comments	Download
A	test/fixedbugs/bug248.go	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug248.dir/bug0.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug248.dir/bug1.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug248.dir/bug2.go	View	1	1 chunk	+92 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug248.dir/bug3.go	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download
M	test/golden.out	View		1 chunk	+1 line, -1 line	0 comments	Download
A	test/typeswitch2.go	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-01-26 02:23:18 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=48b9488dc2fa *** runtime, type switch: eliminate package global name space assumption bonus: ...

15 years, 2 months ago (2010-01-26 02:23:23 UTC) #2

ken3

15 years, 2 months ago (2010-01-26 03:34:39 UTC) #3

LGTM

On 2010/01/26 02:23:23, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=48b9488dc2fa ***
> 
> runtime, type switch: eliminate package global name space assumption
> 
> bonus: type switch now detects multiple uses of identical interface types.
> bonus: interface types are now order-independent, following the spec.
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/194053

Expand All Messages | Collapse All Messages