Issue 193080: code review 193080: gc: record full package paths in runtime type data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 193080: code review 193080: gc: record full package paths in runtime type data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: record full package paths in runtime type data detect compilation of special package runtime with compiler flag instead of package name.

Patch Set 1 #

Patch Set 2 : code review 193080: gc: record full package paths in runtime type data #

Patch Set 3 : code review 193080: gc: record full package paths in runtime type data #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -11 lines)			Patch
M	src/cmd/gc/go.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	src/cmd/gc/go.y	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/cmd/gc/lex.c	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	1	4 chunks	+47 lines, -7 lines	0 comments	Download
M	src/cmd/gc/subr.c	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/reflect/all_test.go	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/Makefile	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-01-25 07:33:50 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=03f4bf1db143 *** gc: record full package paths in runtime type data detect ...

15 years, 2 months ago (2010-01-25 07:34:02 UTC) #2

ken3

15 years, 2 months ago (2010-01-25 09:25:20 UTC) #3

LGTM

On 2010/01/25 07:34:02, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=03f4bf1db143 ***
> 
> gc: record full package paths in runtime type data
> 
> detect compilation of special package runtime with
> compiler flag instead of package name.
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/193080

Expand All Messages | Collapse All Messages