Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 190076: code review 190076: cleanup toward eliminating package global name space (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by rsc
Modified:
15 years, 2 months ago
Reviewers:
CC:
ken2, r, golang-dev
Visibility:
Public.

Description

cleanup toward eliminating package global name space * switch to real dot (.) instead of center dot (·) everywhere in object files. before it was half and half depending on where in the name it appeared. * in 6c/6a/etc identifiers, · can still be used but turns into . immediately. * in export metadata, replace package identifiers with quoted strings (still package names, not paths).

Patch Set 1 #

Patch Set 2 : code review 190076: cleanup toward eliminating package global name space #

Patch Set 3 : code review 190076: cleanup toward eliminating package global name space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -189 lines) Patch
M src/cmd/5g/gobj.c View 1 chunk +1 line, -8 lines 0 comments Download
M src/cmd/5l/noop.c View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/5l/obj.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6g/gobj.c View 1 chunk +1 line, -8 lines 0 comments Download
M src/cmd/6l/pass.c View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M src/cmd/8g/gobj.c View 1 chunk +1 line, -8 lines 0 comments Download
M src/cmd/8l/pass.c View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/cc/lex.c View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M src/cmd/cc/lexbody View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M src/cmd/gc/builtin.c.boot View 1 chunk +84 lines, -84 lines 0 comments Download
M src/cmd/gc/dcl.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/export.c View 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 4 chunks +6 lines, -2 lines 0 comments Download
M src/cmd/gc/go.y View 3 chunks +17 lines, -5 lines 0 comments Download
M src/cmd/gc/mkbuiltin1.c View 3 chunks +15 lines, -2 lines 0 comments Download
M src/cmd/gc/obj.c View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M src/cmd/gc/subr.c View 4 chunks +36 lines, -35 lines 0 comments Download
M src/cmd/gotest/gotest View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/ld/go.c View 1 2 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 2 months ago (2010-01-20 02:44:02 UTC) #1
r
LGTM
15 years, 2 months ago (2010-01-20 03:15:07 UTC) #2
rsc
15 years, 2 months ago (2010-01-20 05:34:48 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=d34a988accfa ***

cleanup toward eliminating package global name space
  * switch to real dot (.) instead of center dot (·) everywhere in object files.
    before it was half and half depending on where in the name it appeared.
  * in 6c/6a/etc identifiers, · can still be used but turns into . immediately.
  * in export metadata, replace package identifiers with quoted strings
    (still package names, not paths).

R=ken2, r
CC=golang-dev
http://codereview.appspot.com/190076
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b