[release-branch.go1.4] code review 189760043: cmd/go: document import path checking

cmd/go: document import path checking

[rsc, 2014-12-09 02:49:22]

Hello adg (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to the release-branch.go1.4 branch of
https://code.google.com/p/go/

[adg1, 2014-12-09 03:00:54]

LGTM

But don't forget to run mkdoc.sh and hg add doc.go.

[rsc, 2014-12-09 03:26:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=c52af0807cc3 ***

[release-branch.go1.4] cmd/go: document import path checking

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/189760043

[rsc, 2014-12-09 03:26:40]

I had to change mkdoc.sh to turn the */ into a * / to avoid terminating the
comment. It's ugly but good enough for now.

[adg1, 2014-12-09 03:31:26]

OK

We just tested; godoc handles

/*
Several comments
*/
// interspersed with lines like this
/*
as a single doc comment.
*/

On 9 December 2014 at 14:26, Russ Cox <rsc@golang.org> wrote:

> I had to change mkdoc.sh to turn the */ into a * / to avoid terminating
> the comment. It's ugly but good enough for now.
>
>

[shurcooL, 2015-01-08 04:47:13]

Hi, I wanted to file an issue related to this section, which is now a part of
the official release docs:

http://golang.org/cmd/go/#hdr-Import_path_checking

However I noticed that section is not present on http://tip.golang.org/cmd/go/.
I then realized it's because this CL/commit,

https://github.com/golang/go/commit/05560adf6246251d084fc08a427ebca7bf1513a1

Is only on release-branch.go1.4 branch and not master/tip.

My questions are, shouldn't it or a similar commit be on tip? Can I still file
an issue about (an inconsistency) its contents?


On 2014/12/09 03:31:26, adg1 wrote:
> OK
> 
> We just tested; godoc handles
> 
> /*
> Several comments
> */
> // interspersed with lines like this
> /*
> as a single doc comment.
> */
> 
> On 9 December 2014 at 14:26, Russ Cox <mailto:rsc@golang.org> wrote:
> 
> > I had to change mkdoc.sh to turn the */ into a * / to avoid terminating
> > the comment. It's ugly but good enough for now.
> >
> >

[adg1, 2015-01-09 02:38:51]

Minux fixed this, thanks for pointing it out.

On 8 January 2015 at 15:47, <shurcooL@gmail.com> wrote:

> Hi, I wanted to file an issue related to this section, which is now a
> part of the official release docs:
>
> http://golang.org/cmd/go/#hdr-Import_path_checking
>
> However I noticed that section is not present on
> http://tip.golang.org/cmd/go/. I then realized it's because this
> CL/commit,
>
> https://github.com/golang/go/commit/05560adf6246251d084fc08a427ebc
> a7bf1513a1
>
> Is only on release-branch.go1.4 branch and not master/tip.
>
> My questions are, shouldn't it or a similar commit be on tip? Can I
> still file an issue about (an inconsistency) its contents?
>
>
> On 2014/12/09 03:31:26, adg1 wrote:
>
>> OK
>>
>
>  We just tested; godoc handles
>>
>
>  /*
>> Several comments
>> */
>> // interspersed with lines like this
>> /*
>> as a single doc comment.
>> */
>>
>
>  On 9 December 2014 at 14:26, Russ Cox <mailto:rsc@golang.org> wrote:
>>
>
>  > I had to change mkdoc.sh to turn the */ into a * / to avoid
>>
> terminating
>
>> > the comment. It's ugly but good enough for now.
>> >
>> >
>>
>
>
> https://codereview.appspot.com/189760043/
>