Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2688)

Issue 1897050: code review 1897050: go/parser.ParseFiles: don't override error (to nil) if ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by gri
Modified:
13 years, 9 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

go/parser.ParseFiles: don't override error (to nil) if there is one Also: Return first instead of last error as that seems more useful.

Patch Set 1 #

Patch Set 2 : code review 1897050: go/parser.ParseFiles: don't override error (to nil) if ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/pkg/go/parser/interface.go View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 3
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 9 months ago (2010-08-04 23:10:32 UTC) #1
r
LGTM
13 years, 9 months ago (2010-08-05 00:30:45 UTC) #2
gri
13 years, 9 months ago (2010-08-05 01:02:45 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e5b35966e162 ***

go/parser.ParseFiles: don't override error (to nil) if there is one

Also: Return first instead of last error as that seems more useful.

R=r
CC=golang-dev
http://codereview.appspot.com/1897050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b