code review 1897046: bikeshed: only output bug when we have a regression

bikeshed: only output bug when we have a regression

[kaib, 2010-07-30 09:26:56]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[kaib, 2010-07-30 09:36:01]

It seemed to me like the only part you are objecting to is when we output for
known bugs. The output should be completely unchanged for all your normal use
cases while still preserving the usefulness for me.

[rsc, 2010-07-30 15:19:31]

On Fri, Jul 30, 2010 at 02:36,  <kaib@golang.org> wrote:
> It seemed to me like the only part you are objecting to is when we
> output for known bugs. The output should be completely unchanged for all
> your normal use cases while still preserving the usefulness for me.

The output is already in pass.out.
Why not just look there?

Russ

[kaib, 2010-07-30 21:21:23]

On Fri, Jul 30, 2010 at 6:19 PM, Russ Cox <rsc@golang.org> wrote:
> On Fri, Jul 30, 2010 at 02:36,  <kaib@golang.org> wrote:
>> It seemed to me like the only part you are objecting to is when we
>> output for known bugs. The output should be completely unchanged for all
>> your normal use cases while still preserving the usefulness for me.
>
> The output is already in pass.out.
> Why not just look there?

The output from run happens while the tests are in progress. With arm
it takes quite a while to run through all the tests so you want to
know sooner rather than later that something failed. You can obviously
do a separate command line to gather the results in a second shell but
I found myself doing this often enough to make this facility is
useful.

This is also just making things consistent. We already output for
tests that regress by throwing a panic or segfault. This is just
adding output for tests that print BUG as well. Given the filter to
mute output for the bugs directory nothing will show up in the normal
case where there are no regressions.

 Kai

[rsc, 2010-07-30 22:26:15]

LGTM

> The output from run happens while the tests are in progress. With arm
> it takes quite a while to run through all the tests so you want to
> know sooner rather than later that something failed. You can obviously
> do a separate command line to gather the results in a second shell but
> I found myself doing this often enough to make this facility is
> useful.
>
> This is also just making things consistent. We already output for
> tests that regress by throwing a panic or segfault. This is just
> adding output for tests that print BUG as well. Given the filter to
> mute output for the bugs directory nothing will show up in the normal
> case where there are no regressions.

That's not entirely true.  I was worried about known broken
tests in the root test directory that are already listed in golden.out.
But there aren't any of those right now, so okay.

[rsc, 2010-08-03 20:09:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=76aa09a38d7f ***

bikeshed: only output bug when we have a regression

R=rsc
CC=golang-dev
http://codereview.appspot.com/1897046

Committer: Russ Cox <rsc@golang.org>