Issue 18920046: code review 18920046: go.tools/dashboard/builder: ignore GOPATH setting durin...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 18920046: code review 18920046: go.tools/dashboard/builder: ignore GOPATH setting durin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by brainman

Modified:
11 years, 7 months ago

Reviewers:
minux1, adg

CC:
golang-dev, minux1, adg

Visibility:
Public.

Description

go.tools/dashboard/builder: ignore GOPATH setting during build (on windows)

Patch Set 1 #

Patch Set 2 : diff -r 75b3759eb0fd https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 75b3759eb0fd https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 68e14846ef5f https://code.google.com/p/go.tools #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	dashboard/builder/env.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 7 months ago (2013-10-30 01:22:01 UTC) #1

brainman

On 2013/10/30 01:29:55, minux wrote: > any rationale for this change? Current version of builder ...

11 years, 7 months ago (2013-10-30 01:34:27 UTC) #3

minux1

sure. LGTM. you might want to wait for one more. the netbsd/386 used to not ...

11 years, 7 months ago (2013-10-30 02:18:57 UTC) #4

brainman

On 2013/10/30 02:18:57, minux wrote: > ... LGTM. you might want to wait for one ...

11 years, 7 months ago (2013-10-30 02:20:05 UTC) #5

brainman

11 years, 7 months ago (2013-11-01 00:28:40 UTC) #8

*** Submitted as
https://code.google.com/p/go/source/detail?r=bf1ade43447c&repo=tools ***

go.tools/dashboard/builder: ignore GOPATH setting during build (on windows)

R=golang-dev, minux.ma, adg
CC=golang-dev
https://codereview.appspot.com/18920046

Expand All Messages | Collapse All Messages