Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2664)

Issue 18850043: code review 18850043: cmd/cgo: stop using -fno-eliminate-unused-debug-types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by rsc
Modified:
10 years, 5 months ago
Reviewers:
minux1
CC:
golang-dev, minux1
Visibility:
Public.

Description

cmd/cgo: stop using -fno-eliminate-unused-debug-types This flag was added in January 2010, in CL 181102, to fix issue 497. (Numbers were just shorter back then.) The fix was for OS X machines and the llvm-gcc frontend. In July 2011 we had to change the way we get enum values, because there were no flags available to force Xcode's llvm-gcc to include the enum names and values in DWARF debug output. We now use clang, not llvm-gcc, on OS X machines. Earlier versions of clang printed a warning about not knowing the flag. Newer versions of clang now make that an error. That is: - The flag was added for OS X machines. - The flag is no longer necessary on OS X machines. - The flag now breaks some OS X machines. Remove it. I have run the original program from issue 497 successfully without the flag on both OS X and Linux machines. Fixes issue 6678.

Patch Set 1 #

Patch Set 2 : diff -r 1a8903f0a577 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1a8903f0a577 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 1a8903f0a577 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 1a8903f0a577 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/cmd/cgo/gcc.go View 1 2 3 4 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 5 months ago (2013-10-29 00:17:57 UTC) #1
minux1
LGTM.
10 years, 5 months ago (2013-10-29 00:19:55 UTC) #2
rsc
10 years, 5 months ago (2013-10-29 02:21:31 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=5ef4bf9eb256 ***

cmd/cgo: stop using -fno-eliminate-unused-debug-types

This flag was added in January 2010, in CL 181102, to fix issue 497.
(Numbers were just shorter back then.) The fix was for OS X machines
and the llvm-gcc frontend.

In July 2011 we had to change the way we get enum values, because
there were no flags available to force Xcode's llvm-gcc to include the
enum names and values in DWARF debug output.

We now use clang, not llvm-gcc, on OS X machines.
Earlier versions of clang printed a warning about not knowing the flag.
Newer versions of clang now make that an error.

That is:
 - The flag was added for OS X machines.
 - The flag is no longer necessary on OS X machines.
 - The flag now breaks some OS X machines.

Remove it.

I have run the original program from issue 497 successfully
without the flag on both OS X and Linux machines.

Fixes issue 6678.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/18850043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b