Issue 187770043: code review 187770043: runtime: convert netbsd/arm to Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 187770043: code review 187770043: runtime: convert netbsd/arm to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rsc

Modified:
10 years, 3 months ago

Reviewers:
austin

CC:
austin, golang-codereviews

Visibility:
Public.

Description

runtime: convert netbsd/arm to Go This was the last src/runtime/*.c file.

Patch Set 1 #

Patch Set 2 : diff -r faa3ed1dc30e42771a68b6337dcf8be9518d5c07 https://code.google.com/p/go/ #

Patch Set 3 : diff -r faa3ed1dc30e42771a68b6337dcf8be9518d5c07 https://code.google.com/p/go/ #

Patch Set 4 : diff -r faa3ed1dc30e42771a68b6337dcf8be9518d5c07 https://code.google.com/p/go/ #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -52 lines)			Patch
M	src/runtime/defs1_netbsd_arm.go	View	1	3 chunks	+21 lines, -8 lines	0 comments	Download
M	src/runtime/os_netbsd_arm.go	View	1	1 chunk	+14 lines, -20 lines	0 comments	Download
M	src/runtime/signal_netbsd_arm.go	View	1	1 chunk	+42 lines, -24 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello austin (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 3 months ago (2014-12-05 18:20:14 UTC) #1

rsc

10 years, 3 months ago (2014-12-05 21:17:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f1594a821ec0 ***

runtime: convert netbsd/arm to Go

This was the last src/runtime/*.c file.

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/187770043

Expand All Messages | Collapse All Messages