Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(109)

Issue 1868041: code review 1868041: change line pragma from (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by ken3
Modified:
14 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

change line pragma from //line number file to //line file:number

Patch Set 1 #

Patch Set 2 : code review 1868041: change line pragma from #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M src/cmd/gc/lex.c View 4 chunks +29 lines, -28 lines 0 comments Download
M src/cmd/goyacc/goyacc.go View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3
ken3
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-07-16 20:34:34 UTC) #1
ken3
*** Submitted as http://code.google.com/p/go/source/detail?r=15f73963e3cd *** change line pragma from //line number file to //line file:number ...
14 years, 8 months ago (2010-07-16 20:34:38 UTC) #2
rsc1
14 years, 8 months ago (2010-07-16 20:37:54 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b