Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 1863042: code review 1863042: interpret lines that look like (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by ken3
Modified:
14 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

interpret lines that look like //line 10 units.y which is equiv to c #line 10 units.y the purpose is to generate diagnostics that correctly point to preprocessed source.

Patch Set 1 #

Patch Set 2 : code review 1863042: interpret lines that look like #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -14 lines) Patch
M src/cmd/gc/lex.c View 4 chunks +60 lines, -1 line 0 comments Download
M src/cmd/gc/subr.c View 3 chunks +23 lines, -11 lines 0 comments Download
M src/cmd/goyacc/goyacc.go View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3
ken3
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-07-16 03:21:32 UTC) #1
ken3
*** Submitted as http://code.google.com/p/go/source/detail?r=985c187b6b83 *** interpret lines that look like //line 10 units.y which is ...
14 years, 8 months ago (2010-07-16 03:21:35 UTC) #2
rsc
14 years, 8 months ago (2010-07-16 03:28:26 UTC) #3
LGTM

but the form should be

//line units.y:10
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b