Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(536)

Issue 1862042: code review 1862042: gc: bug293 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by rsc
Modified:
14 years, 8 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: bug293 Fixes issue 846.

Patch Set 1 #

Patch Set 2 : code review 1862042: gc: bug293 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -10 lines) Patch
M src/cmd/5g/ggen.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/6g/ggen.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/8g/ggen.c View 2 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/gc/walk.c View 2 chunks +9 lines, -1 line 0 comments Download
A test/fixedbugs/bug293.go View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-07-15 23:14:05 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=26def27a6036 *** gc: bug293 Fixes issue 846. R=ken2 CC=golang-dev http://codereview.appspot.com/1862042
14 years, 8 months ago (2010-07-15 23:14:09 UTC) #2
ken3
14 years, 8 months ago (2010-07-16 00:21:43 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b