code review 186119: clean up handling of numeric time zones

clean up handling of numeric time zones
allow formatting of ruby-style times.

Fixes issue 518.

[r, 2010-01-13 05:32:03]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-01-13 05:53:30]

http://codereview.appspot.com/186119/diff/1/2
File src/pkg/time/format.go (right):

http://codereview.appspot.com/186119/diff/1/2#newcode30
src/pkg/time/format.go:30: // Special case: use z to get the time zone formatted
like -0700.
This special case seems unnecessary.
Can we use -0700 instead?
I know it's more code but it keeps the interface simple.
If we use "z" for anything I would want to save it for
RFC 3339 (Z but with a :).

[r2, 2010-01-13 05:56:54]

On Jan 13, 2010, at 4:53 PM, rsc@golang.org wrote:

>
> http://codereview.appspot.com/186119/diff/1/2
> File src/pkg/time/format.go (right):
>
> http://codereview.appspot.com/186119/diff/1/2#newcode30
> src/pkg/time/format.go:30: // Special case: use z to get the time zone
> formatted like -0700.
> This special case seems unnecessary.
> Can we use -0700 instead?
> I know it's more code but it keeps the interface simple.
> If we use "z" for anything I would want to save it for
> RFC 3339 (Z but with a :).

i tried that before and it was pretty messy.

let me think about it.  this is about the 10th version of the code  
today. i'll see if there's an 11th that will work.

-rob

[r2, 2010-01-13 23:45:11]

one ugly hack got me there. PTAL.

-rob

[rsc, 2010-01-14 00:55:48]

LGTM

http://codereview.appspot.com/186119/diff/12/13
File src/pkg/time/format.go (right):

http://codereview.appspot.com/186119/diff/12/13#newcode220
src/pkg/time/format.go:220: if soFar[len(soFar)-1] == '-' && zone > 0 {
s/>/>=/

[r, 2010-01-14 00:57:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=0f80c5e80c0e ***

clean up handling of numeric time zones
allow formatting of ruby-style times.

Fixes issue 518.

R=rsc
CC=golang-dev
http://codereview.appspot.com/186119