Issue 185790043: code review 185790043: [release-branch.go1.4] go-tour: update sub-repo import paths

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 185790043: code review 185790043: [release-branch.go1.4] go-tour: update sub-repo import paths

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by minux

Modified:
9 years, 5 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] go-tour: update sub-repo import paths ««« CL 178510043 / 27216d4d0984 gotour: update sub-repo import paths LGTM=adg R=adg CC=golang-codereviews https://codereview.appspot.com/178510043 »»» ««« CL 176670043 / 87dccf852df4 go-tour: update sub-repo import path I missed the appengine one in last CL. LGTM=adg R=adg CC=golang-codereviews https://codereview.appspot.com/176670043 »»»

Patch Set 1 #

Patch Set 2 : diff -r dbbfe56360c1926e9aa085211af1275371603d9a https://code.google.com/p/go-tour #

Patch Set 3 : diff -r dbbfe56360c1926e9aa085211af1275371603d9a https://code.google.com/p/go-tour #

Patch Set 4 : diff -r dbbfe56360c1926e9aa085211af1275371603d9a https://code.google.com/p/go-tour #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	gotour/appengine.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gotour/local.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gotour/tour.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 5 months ago (2014-12-03 04:44:19 UTC) #1

minux

Note: I combined release-apply for CL 178510043 and 176670043, which logically should be the same ...

9 years, 5 months ago (2014-12-03 04:45:33 UTC) #2

adg

LGTM On Wed Dec 03 2014 at 3:45:35 PM minux <minux@golang.org> wrote: > Note: I ...

9 years, 5 months ago (2014-12-03 04:56:40 UTC) #3

minux

9 years, 5 months ago (2014-12-03 04:58:15 UTC) #4

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=90b205896115
***

[release-branch.go1.4] go-tour: update sub-repo import paths

««« CL 178510043 / 27216d4d0984
gotour: update sub-repo import paths

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/178510043
»»»

««« CL 176670043 / 87dccf852df4
go-tour: update sub-repo import path
I missed the appengine one in last CL.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/176670043
»»»

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/185790043

Expand All Messages | Collapse All Messages