Issue 1857049: code review 1857049: syscall: make sure go error numbers do not clash with w...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1857049: code review 1857049: syscall: make sure go error numbers do not clash with w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by brainman

Modified:
14 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

syscall: make sure go error numbers do not clash with windows system errors

Patch Set 2 : code review 1857049: syscall: make sure go error numbers do not clash with w... #

Total comments: 2

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+333 lines, -187 lines)			Patch
M	src/pkg/syscall/mkall.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/mkerrors_windows.sh	View	4 chunks	+38 lines, -44 lines	0 comments	Download
M	src/pkg/syscall/mksyscall_windows.sh	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/zerrors_windows_386.go	View	1 chunk	+265 lines, -137 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_386.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/ztypes_windows_386.go	View	1 chunk	+19 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 7 months ago (2010-08-02 07:09:03 UTC) #1

rsc1

LGTM with fixes http://codereview.appspot.com/1857049/diff/2001/3007 File src/pkg/syscall/ztypes_windows_386.go (right): http://codereview.appspot.com/1857049/diff/2001/3007#newcode32 src/pkg/syscall/ztypes_windows_386.go:32: // errors. Application-defined errors (as per ...

14 years, 7 months ago (2010-08-02 22:51:41 UTC) #2

brainman

Thanks for your review. http://codereview.appspot.com/1857049/diff/2001/3007 File src/pkg/syscall/ztypes_windows_386.go (right): http://codereview.appspot.com/1857049/diff/2001/3007#newcode32 src/pkg/syscall/ztypes_windows_386.go:32: // errors. Application-defined errors (as ...

14 years, 7 months ago (2010-08-03 02:03:55 UTC) #3

brainman

14 years, 7 months ago (2010-08-03 02:04:45 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b5655a188963 ***

syscall: make sure go error numbers do not clash with windows system errors

R=rsc
CC=golang-dev
http://codereview.appspot.com/1857049

Committer: Alex Brainman <alex.brainman@gmail.com>

Expand All Messages | Collapse All Messages