code review 185050043: cmd/api: make API check fail for undeclared API in rele...

cmd/api: make API check fail for undeclared API in release branch

We forgot to do the usual API review.
Make that not possible in the future.
I'll pull this change over to the main
branch too, but it's more important
(and only testable) here.

[rsc, 2014-12-05 18:43:51]

Hello bradfitz (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2014-12-05 18:59:57]

I also added code to ignore blank lines and lines beginning with # in the
api.txt files. I intend to use those to make the upcoming Go 1.4 API review
a bit easier.

[bradfitz, 2014-12-05 19:02:12]

LGTM

[rsc, 2014-12-05 19:04:23]

*** Submitted as https://code.google.com/p/go/source/detail?r=d767a00b3264 ***

[release-branch.go1.4] cmd/api: make API check fail for undeclared API in
release branch

We forgot to do the usual API review.
Make that not possible in the future.
I'll pull this change over to the main
branch too, but it's more important
(and only testable) here.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/185050043

[gobot, 2014-12-05 19:10:07]

This CL appears to have broken the solaris-amd64-smartos builder.
See http://build.golang.org/log/ffc11f7926587c14d5c47b0fa312346e5190d793

[aram, 2014-12-07 11:34:46]

On 2014/12/05 19:10:07, gobot wrote:
> This CL appears to have broken the solaris-amd64-smartos builder.
> See http://build.golang.org/log/ffc11f7926587c14d5c47b0fa312346e5190d793

Should I fix this in hg or git?

[adg, 2014-12-07 22:10:37]

How do you intend to fix it? There's a CL out to add go1.4.txt which should
fix this failure. It's not solaris-specific.

On Sun Dec 07 2014 at 10:34:49 PM <aram@mgk.ro> wrote:

> On 2014/12/05 19:10:07, gobot wrote:
> > This CL appears to have broken the solaris-amd64-smartos builder.
> > See
> http://build.golang.org/log/ffc11f7926587c14d5c47b0fa312346e5190d793
>
> Should I fix this in hg or git?
>
>
> https://codereview.appspot.com/185050043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[aram, 2014-12-07 23:09:04]

Ah, ok. Solaris never had the API check at all.

-- 
Aram Hăvărneanu