Issue 1849055: code review 1849055: fix build: literal types cannot be parenthesized anymore

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1849055: code review 1849055: fix build: literal types cannot be parenthesized anymore (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by gri

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

fix build: literal types cannot be parenthesized anymore

Patch Set 1 #

Patch Set 2 : code review 1849055: fix build: literal types cannot be parenthesized anymore #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -21 lines)			Patch
M	src/pkg/go/printer/testdata/expressions.golden	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.input	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.raw	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 9 months ago (2010-08-05 00:56:28 UTC) #1

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=705a8b32e404 *** fix build: literal types cannot be parenthesized anymore R=rsc CC=golang-dev ...

13 years, 9 months ago (2010-08-05 00:58:58 UTC) #2

LGTM

Expand All Messages | Collapse All Messages