Issue 1848056: code review 1848056: gc: index bounds tests and fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1848056: code review 1848056: gc: index bounds tests and fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rsc

Modified:
14 years, 7 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: index bounds tests and fixes move constant index checking to front end x[2:1] is a compile-time error now too

Patch Set 1 #

Patch Set 2 : code review 1848056: gc: index bounds tests and fixes #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+446 lines, -111 lines)			Patch
M	src/cmd/5g/cgen.c	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/cmd/5g/ggen.c	View		3 chunks	+27 lines, -0 lines	0 comments	Download
M	src/cmd/5g/gsubr.c	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/cmd/6g/cgen.c	View	1	4 chunks	+20 lines, -15 lines	0 comments	Download
M	src/cmd/6g/ggen.c	View		3 chunks	+35 lines, -15 lines	0 comments	Download
M	src/cmd/6g/gsubr.c	View	1	4 chunks	+17 lines, -16 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/cmd/8g/ggen.c	View		3 chunks	+42 lines, -5 lines	0 comments	Download
M	src/cmd/gc/builtin.c.boot	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/const.c	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/cmd/gc/mparith2.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/runtime.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/walk.c	View		6 chunks	+56 lines, -16 lines	0 comments	Download
M	src/pkg/runtime/slice.c	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
A	test/index.go	View	1	1 chunk	+224 lines, -0 lines	0 comments	Download
M	test/recover2.go	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-08-03 07:26:01 UTC) #1

rsc

14 years, 7 months ago (2010-08-03 07:26:09 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=36a0537583f1 ***

gc: index bounds tests and fixes
move constant index checking to front end
x[2:1] is a compile-time error now too

R=ken2
CC=golang-dev
http://codereview.appspot.com/1848056

Expand All Messages | Collapse All Messages