Issue 1847047: code review 1847047: arm: bugfixes and syscall

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1847047: code review 1847047: arm: bugfixes and syscall (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by kaib

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, brad_danga_com, golang-dev

Visibility:
Public.

Description

arm: bugfixes and syscall - integer divide by zero raises panic - float comparisons involving NaNs work - syscall interface actually handles return values and errno correctly.

Patch Set 1 #

Patch Set 2 : code review 1847047: arm: bugfixes and syscall #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+446 lines, -393 lines)			Patch
M	src/cmd/5g/cgen.c	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	src/pkg/runtime/arm/vlop.s	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/arm/vlrt.c	View		11 chunks	+391 lines, -382 lines	0 comments	Download
M	src/pkg/syscall/asm_linux_arm.s	View	1	3 chunks	+42 lines, -7 lines	0 comments	Download
M	test/arm-pass.txt	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kaib

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-07-30 12:09:17 UTC) #1

brad_danga_com

FYI, this CL fixes: http://code.google.com/p/go/issues/detail?id=913

14 years, 9 months ago (2010-08-01 01:01:00 UTC) #2

rsc

14 years, 8 months ago (2010-08-06 23:57:51 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=8e04948fa317 ***

arm: bugfixes and syscall

- integer divide by zero raises panic
- float comparisons involving NaNs work
- syscall interface actually handles return
  values and errno correctly.

R=rsc, bradfitzpatrick
CC=golang-dev
http://codereview.appspot.com/1847047

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages