Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 1842042: code review 1842042: cgo: If CC is set in environment, use it rather than "gcc". (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by iant
Modified:
14 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cgo: If CC is set in environment, use it rather than "gcc".

Patch Set 1 #

Patch Set 2 : code review 1842042: cgo: If CC is set in environment, use it rather than "gcc". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/cmd/cgo/gcc.go View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-07-16 08:33:17 UTC) #1
rsc
LGTM
14 years, 8 months ago (2010-07-16 17:57:20 UTC) #2
iant
14 years, 8 months ago (2010-07-16 18:01:10 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=4a1fcee4b6e8 ***

cgo: If CC is set in environment, use it rather than "gcc".

R=rsc
CC=golang-dev
http://codereview.appspot.com/1842042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b