Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(334)

Issue 183140043: code review 183140043: all: merge dev.garbage (d1238958d4ae) into default branch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rsc
Modified:
10 years, 3 months ago
Reviewers:
gobot
CC:
rlh, golang-codereviews
Visibility:
Public.

Description

all: merge dev.garbage (d1238958d4ae) into default branch When we start work on Gerrit, ppc64 and garbage collection work will continue in the master branch, not the dev branches. (We may still use dev branches for other things later, but these are ready to be merged, and doing it now, before moving to Git means we don't have to have dev branches working in the Gerrit workflow on day one.)

Patch Set 1 #

Patch Set 2 : diff -r 4d000340a76822ab21a6393ab03313971f6ea01d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4d000340a76822ab21a6393ab03313971f6ea01d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1926 lines, -590 lines) Patch
M lib/codereview/codereview.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/gc/builtin.c View 1 2 chunks +28 lines, -3 lines 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 2 chunks +30 lines, -3 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/cmd/gc/walk.c View 1 7 chunks +55 lines, -8 lines 0 comments Download
M src/runtime/asm_386.s View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/runtime/asm_amd64.s View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/runtime/asm_amd64p32.s View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/runtime/asm_arm.s View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/asm_ppc64x.s View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/export_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/heapdump.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/lfstack.go View 1 2 chunks +3 lines, -7 lines 0 comments Download
M src/runtime/lfstack_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/malloc.go View 1 8 chunks +76 lines, -7 lines 0 comments Download
M src/runtime/malloc2.go View 1 4 chunks +32 lines, -9 lines 0 comments Download
M src/runtime/mcache.go View 1 3 chunks +8 lines, -3 lines 0 comments Download
M src/runtime/mcentral.go View 1 5 chunks +17 lines, -13 lines 0 comments Download
M src/runtime/mgc.go View 1 27 chunks +975 lines, -348 lines 0 comments Download
M src/runtime/mgc0.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime/mgc0.go View 1 1 chunk +128 lines, -27 lines 0 comments Download
M src/runtime/mgc1.go View 1 1 chunk +7 lines, -4 lines 0 comments Download
M src/runtime/mheap.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/os_linux_386.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/print1.go View 1 3 chunks +27 lines, -3 lines 0 comments Download
M src/runtime/proc.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/proc1.go View 1 10 chunks +38 lines, -18 lines 0 comments Download
M src/runtime/rt0_linux_386.s View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime1.go View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/runtime/runtime2.go View 1 3 chunks +11 lines, -6 lines 0 comments Download
M src/runtime/select.go View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/runtime/stack.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stack1.go View 1 16 chunks +45 lines, -33 lines 0 comments Download
M src/runtime/stack2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stubs.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/vdso_none.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/wbfat.go View 1 1 chunk +190 lines, -0 lines 0 comments Download
M src/runtime/wbfat_gen.go View 1 1 chunk +41 lines, -0 lines 0 comments Download
M src/sync/atomic/atomic_test.go View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/live.go View 1 23 chunks +86 lines, -66 lines 0 comments Download
M test/live2.go View 1 3 chunks +4 lines, -2 lines 0 comments Download
M test/nosplit.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello rlh (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 3 months ago (2014-12-06 01:34:44 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=94be5d381354 *** all: merge dev.garbage (d1238958d4ae) into default branch When we start ...
10 years, 3 months ago (2014-12-06 01:34:51 UTC) #2
gobot
10 years, 3 months ago (2014-12-06 01:40:16 UTC) #3
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64-race builder.
See http://build.golang.org/log/95be08ad29f2889bb256f7ba5c7714f3ca3fec25
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b