Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(138)

Issue 183110043: code review 183110043: x/talks/2014/readability: add missing images, and some ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by minux
Modified:
9 years, 3 months ago
Reviewers:
ukai, adg1, mattn
CC:
r, adg, mattn, adg1, golang-codereviews
Visibility:
Public.

Description

x/talks/2014/readability: add missing images, and some cosmetic fixes Somehow the images in the original CL (176660043) were dropped when committing that CL.

Patch Set 1 #

Patch Set 2 : diff -r d95b15e80dcbf207bb1b8eb3c822112604f6544a https://code.google.com/p/go.talks #

Patch Set 3 : diff -r d95b15e80dcbf207bb1b8eb3c822112604f6544a https://code.google.com/p/go.talks #

Patch Set 4 : diff -r d95b15e80dcbf207bb1b8eb3c822112604f6544a https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M 2014/readability.slide View 1 9 chunks +10 lines, -15 lines 0 comments Download
A 2014/readability/gopher-ok-no.png View 1 Binary file 0 comments Download
A 2014/readability/gophers5th.jpg View 1 Binary file 0 comments Download
A 2014/readability/pkg.png View 1 Binary file 0 comments Download
A 2014/readability/project.png View 1 Binary file 0 comments Download
A 2014/readability/ref.png View 1 Binary file 0 comments Download
A 2014/readability/talks.png View 1 Binary file 0 comments Download

Messages

Total messages: 7
minux
Hello ukai@google.com, r@golang.org, adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
9 years, 3 months ago (2014-12-05 02:48:02 UTC) #1
minux
Note: the larger changes to the content are to make sure the content can be ...
9 years, 3 months ago (2014-12-05 02:52:54 UTC) #2
mattn
On 2014/12/05 02:52:54, minux wrote: > Note: the larger changes to the content are to ...
9 years, 3 months ago (2014-12-05 02:54:42 UTC) #3
adg1
LGTM
9 years, 3 months ago (2014-12-05 03:28:07 UTC) #4
minux
*** Submitted as https://code.google.com/p/go/source/detail?r=197657ae0715&repo=talks *** x/talks/2014/readability: add missing images, and some cosmetic fixes Somehow the ...
9 years, 3 months ago (2014-12-05 03:58:19 UTC) #5
minux
Andrew, please re-deploy the talks app. Thanks.
9 years, 3 months ago (2014-12-05 04:00:39 UTC) #6
ukai
9 years, 3 months ago (2014-12-08 02:23:45 UTC) #7
Message was sent while issue was closed.
On 2014/12/05 04:00:39, minux wrote:
> Andrew, please re-deploy the talks app. Thanks.

Thanks for fixing!
I've some minor fixes. https://codereview.appspot.com/188790043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b