Issue 183080043: code review 183080043: cmd/pprof: fix symbol resolution for remote profiles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183080043: code review 183080043: cmd/pprof: fix symbol resolution for remote profiles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by rsc

Modified:
9 years, 4 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant, austin, minux

Visibility:
Public.

Description

cmd/pprof: fix symbol resolution for remote profiles Fixes issue 9199.

Patch Set 1 #

Patch Set 2 : diff -r 871468f5ceaf21cccedbae34bb40abc34d0d1737 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 871468f5ceaf21cccedbae34bb40abc34d0d1737 https://code.google.com/p/go/ #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/pprof/internal/symbolizer/symbolizer.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: austin, minux), I'd like you to review this change to https://code.google.com/p/go/

9 years, 4 months ago (2014-12-03 18:54:56 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=b663cc7e6c15 *** cmd/pprof: fix symbol resolution for remote profiles Fixes issue 9199. ...

9 years, 4 months ago (2014-12-03 19:14:07 UTC) #3

gobot

9 years, 4 months ago (2014-12-03 19:21:00 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-race builder.
See http://build.golang.org/log/e6c306a15d0f3e97bb54b94e122f6aae0ae5ca96

Expand All Messages | Collapse All Messages