Issue 182740043: code review 182740043: [release-branch.go1.4] go/build: build $GOOS_test.go always

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182740043: code review 182740043: [release-branch.go1.4] go/build: build $GOOS_test.go always (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by rsc

Modified:
9 years, 4 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] go/build: build $GOOS_test.go always ««« CL 176290043 / 8025b7d1e6c9 go/build: build $GOOS_test.go always We decided to build $GOOS.go always but forgot to test $GOOS_test.go. Fixes issue 9159. LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/176290043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 926c82fb5dadaf49a40180cbf626a5ccb557f20b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 926c82fb5dadaf49a40180cbf626a5ccb557f20b https://code.google.com/p/go/ #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/go/build/build.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
	M	src/go/build/build_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 4 months ago (2014-11-25 01:19:18 UTC) #1

rsc

9 years, 4 months ago (2014-11-25 03:00:09 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ca6f546501c8 ***

[release-branch.go1.4] go/build: build $GOOS_test.go always

««« CL 176290043 / 8025b7d1e6c9
go/build: build $GOOS_test.go always

We decided to build $GOOS.go always
but forgot to test $GOOS_test.go.

Fixes issue 9159.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/176290043
»»»

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/182740043

Expand All Messages | Collapse All Messages