code review 182510043: go-tour: The TOC click-catcher shouldn't cover the TOC ...

go-tour: The TOC click-catcher shouldn't cover the TOC scrollbar.

Fixes 183

[francesc, 2014-12-05 04:36:29]

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go-tour

[adg, 2014-12-05 05:28:34]

LGTM
On Fri, 5 Dec 2014 at 14:36, <campoy@golang.org> wrote:

> Reviewers: adg,
>
> Message:
> Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go-tour
>
>
> Description:
> go-tour: The TOC click-catcher shouldn't cover the TOC scrollbar.
>
> Fixes 183
>
> Please review this at https://codereview.appspot.com/182510043/
>
> Affected files (+1, -1 lines):
>    M static/css/app.css
>
>
> Index: static/css/app.css
> ===================================================================
> --- a/static/css/app.css
> +++ b/static/css/app.css
> @@ -458,7 +458,7 @@
>       top:0;
>       bottom: 0;
>       left:0;
> -    right: 0;
> +    right: 10;  /* avoid covering the TOC scroller */
>       background: rgba(0, 0, 0, 0);
>   }
>   .toc * {
>
>
>

[francesc, 2014-12-05 20:10:18]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=38aaff428e50
***

go-tour: The TOC click-catcher shouldn't cover the TOC scrollbar.

Fixes 183

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/182510043

[atdiar, 2014-12-06 00:35:49]

On 2014/12/05 20:10:18, francesc wrote:
> *** Submitted as
https://code.google.com/p/go-tour/source/detail?r=38aaff428e50
> ***
> 
> go-tour: The TOC click-catcher shouldn't cover the TOC scrollbar.
> 
> Fixes 183
> 
> LGTM=adg
> R=adg
> CC=golang-codereviews
> https://codereview.appspot.com/182510043

At the risk of being annoying, don't you need a length unit ? :)