Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(915)

Issue 182490043: code review 182490043: x/talks/2014/readability: fix build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by minux
Modified:
9 years, 3 months ago
Reviewers:
mattn, adg1
CC:
golang-codereviews, adg1
Visibility:
Public.

Description

x/talks/2014/readability: fix build.

Patch Set 1 #

Patch Set 2 : diff -r 38cc85636e1f934a1164b33ce7320d2c34b88347 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 38cc85636e1f934a1164b33ce7320d2c34b88347 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 38cc85636e1f934a1164b33ce7320d2c34b88347 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r 38cc85636e1f934a1164b33ce7320d2c34b88347 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M 2014/readability/close-cond-bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/close-cond-good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/err_close_write_bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/err_close_write_good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/err_regexp_bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/err_regexp_good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/example_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/if-else-bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/if-else-good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/if-switch-bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/if-switch-good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/implement-interface-bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/implement-interface-good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/in-band-error.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/in-band-error-client.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/long-line-fold.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/long-line-nofold.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/long-line-short.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/nil_error.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/nil_interface_en.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/reflect-bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/reflect-good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/resthandler.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/resthandler-fix2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/struct-field-bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/struct-field-good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/test-pattern_en.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/time_duration_bad.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/time_duration_bad1.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/time_duration_bad2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/time_duration_good.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/readability/val-and-error.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
minux
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
9 years, 3 months ago (2014-12-05 01:39:08 UTC) #1
adg1
LGTM
9 years, 3 months ago (2014-12-05 01:41:36 UTC) #2
minux
*** Submitted as https://code.google.com/p/go/source/detail?r=d95b15e80dcb&repo=talks *** x/talks/2014/readability: fix build. LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://codereview.appspot.com/182490043
9 years, 3 months ago (2014-12-05 01:44:32 UTC) #3
mattn
9 years, 3 months ago (2014-12-05 02:17:25 UTC) #4
Sorry OT

http://talks.golang.org/2014/readability.slide#2

project.png is missing.

On Friday, December 5, 2014 10:44:32 AM UTC+9, minux wrote:
>
> *** Submitted as 
> https://code.google.com/p/go/source/detail?r=d95b15e80dcb&repo=talks *** 
>
> x/talks/2014/readability: fix build. 
>
> LGTM=adg 
> R=golang-codereviews, adg 
> CC=golang-codereviews 
> https://codereview.appspot.com/182490043 
>
>
> https://codereview.appspot.com/182490043/ 
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b